disableMD5 option is allowed in the spec, but ignored

mongodb · Oct 30, 2024 · 15fc90a · 15fc90a
1 parent 3317992
commit 15fc90a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/UnifiedSpecTests/Context.php b/tests/UnifiedSpecTests/Context.php
@@ -463,7 +463,10 @@ private function createSession(string $id, stdClass $o): void
 
     private function createBucket(string $id, stdClass $o): void
     {
-        Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions']);
+        // Option "disableMD5" is transitional while other drivers remove support
+        // for "md5" fields. It is ignored since PHPLIB v2.0.
+        // https://github.com/mongodb/specifications/blob/9058491f2d5b5651913a56e373121a24d6498673/source/gridfs/gridfs-spec.md?plain=1#L281-L288
+        Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions', 'disableMD5']);
 
         $databaseId = $o->database ?? null;
         assertIsString($databaseId);

diff --git a/tests/UnifiedSpecTests/Operation.php b/tests/UnifiedSpecTests/Operation.php
@@ -770,9 +770,6 @@ private function executeForBucket(Bucket $bucket)
     {
         $args = $this->prepareArguments();
 
-        // "md5" field is removed from the spec, option "disableMD5" is ignored
-        unset($args['disableMD5']);
-
         Util::assertArgumentsBySchema(Bucket::class, $this->name, $args);
 
         switch ($this->name) {