LG-4620: ChartCard and Header components
#2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 215c193.
🦋 Changeset detectedLatest commit: 78c8b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +2.07 kB (+0.15%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
tsck
commented
Nov 20, 2024
| | `onChartReady` | Callback to be called when chart is finished rendering. | () => void | | | ||
| | Name | Description | Type | Default | | ||
| | -------------- | ------------------------------------------------------- | ------------ | ------- | | ||
| | `onChartReady` | Callback to be called when chart is finished rendering. | `() => void` | | |
There was a problem hiding this comment.
Made some drive-by style changes in the README, mostly to use backticks on some code that wasn't previously formatted
tsck
commented
Nov 20, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
| className={cx( | ||
| getContainerStyles(theme, height, headerHeight), | ||
| className, | ||
| isOpen && 'open', |
There was a problem hiding this comment.
We don't typically use this pattern. An alternative could be to pass isOpen to getContainerStyles(theme, height, headerHeight, isOpen) and then conditionally render the style:
export const getContainerStyles = (
theme: Theme,
height?: number,
headerHeight?: number,
isOpen,
) => cx(css`
... default styles here
`,
{
[css`
... open styles here
`]: isOpen
}
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 21, 2024
shaneeza
reviewed
Nov 22, 2024
| grid-template-rows: 40px 0fr; | ||
| transition: grid-template-rows ${transitionDuration.slower}ms ease-in-out; | ||
|
|
||
| &.open { |
There was a problem hiding this comment.
Curious: why do you prefer using .open instead of conditionally rendering the styles with cx?
There was a problem hiding this comment.
Actually not a preference, just not used to having cx as an option! Will update this.
shaneeza
reviewed
Nov 22, 2024
| > | ||
| <Icon | ||
| glyph="ChevronDown" | ||
| className={cx(toggleIconStyles, isOpen && 'open')} |
shaneeza
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This adds both
ChartCardandHeadercomponents.🎟 Jira tickets:
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes