LG-4146: Table refactor
#2546
Draft
LG-4146: Table refactor
#2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* temp removal of transitions * remove nested stories * remove flatten packages
…factor-integration
* wip * wip * updating stories * lg virtual item * top styles * remove padding from TableBody * expanded row background color * removing stuff * row context * memoizing stuff * wip * styled components * comments * more cleanup * clean up * comments * wip, memoize regular table * testing * huh * why does this work? * testing why nothing works * clean up * update virtual stories * clean up * cleanup * row types * types * should truncate support * remove memo from useLeafyGreenVirtualTable * remove unsed exports * add a new story * widths and vertical align * dynamic ellipsis * comment * combined components * cell generic type * update types * align styles * Prerelease version packages 13.0.0-beta.0 * fix install error * Prerelease version packages 13.0.0-beta.1 * comment, wip * revert useLeafyGreenTable hook so its consistent with a virtual table * add getItemKey * small fix * stop mapping columns def * testing * debugging * tbody updates * css vars * add virtual context * remove comment * remove measureElement from hook * row context updates * remove overflow from regular table * updates virtual types * more TS docs * ts fixes * row TS docs * TS docs stuff * fix comment * remove original from rowCopy * story clean up * remove v10 and v11 adapter * remove react-virtual * cell styles * interrowwithRT style updates * table styles * comment * comment * story with less rows * cell ternary, headercell util, expandedcontent styles * fb - toggleExpand, isVirtual boolean, type casting, tsdocs * virtual scrolling padding util * forgot to save * fb - remove virtual context * custom row model * styledcomponent stuff, TS still not correct * callable virtual items * update ts docs * token * feedback
|
|
Size Change: -11.7 kB (-0.84%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
shaneeza
commented
Nov 19, 2024
| @@ -1,5 +1,17 @@ | |||
| # @leafygreen-ui/table | |||
|
|
|||
| ## 13.0.0-beta.1 | |||
There was a problem hiding this comment.
Add changeset files
* wip * wip * updating stories * lg virtual item * top styles * remove padding from TableBody * expanded row background color * removing stuff * row context * memoizing stuff * wip * styled components * comments * more cleanup * clean up * comments * wip, memoize regular table * testing * huh * why does this work? * testing why nothing works * clean up * update virtual stories * clean up * cleanup * row types * types * should truncate support * remove memo from useLeafyGreenVirtualTable * remove unsed exports * add a new story * widths and vertical align * dynamic ellipsis * comment * combined components * cell generic type * update types * align styles * Prerelease version packages 13.0.0-beta.0 * fix install error * Prerelease version packages 13.0.0-beta.1 * comment, wip * added forwardrefs to cells and tds * add tests for useMergeRefs * forwardRef test * Row export * headerRow forwardref test * TableBody forwardRef test * TableHeader forwardRef test * Cell forwardRef test * HeaderCell ForwardRef test * ExpandedContent ForwardRef test * update test * comments * revert useLeafyGreenTable hook so its consistent with a virtual table * fix story * small fix * add getItemKey * small fix * stop mapping columns def * testing * debugging * tbody updates * css vars * add virtual context * remove comment * remove measureElement from hook * remove getAreAncestorsExpanded util * row context updates * remove overflow from regular table * move Generic type to lib * updating comments * fix cell fwdRef test * comments * updates virtual types * more TS docs * ts fixes * row TS docs * TS docs stuff * fix comment * remove original from rowCopy * story clean up * remove v10 and v11 adapter * fix test * remove react-virtual * cell styles * interrowwithRT style updates * table styles * comment * comment * comment * story with less rows * cell ternary, headercell util, expandedcontent styles * fb - toggleExpand, isVirtual boolean, type casting, tsdocs * virtual scrolling padding util * forgot to save * fb - remove virtual context * custom row model * styledcomponent stuff, TS still not correct * callable virtual items * update ts docs * token * feedback * updates
shaneeza
changed the title
Table refactor integration Table refactor integration
* wip * wip * updating stories * lg virtual item * top styles * remove padding from TableBody * expanded row background color * removing stuff * row context * memoizing stuff * wip * styled components * comments * more cleanup * clean up * comments * wip, memoize regular table * testing * huh * why does this work? * testing why nothing works * clean up * update virtual stories * clean up * cleanup * row types * types * should truncate support * remove memo from useLeafyGreenVirtualTable * remove unsed exports * add a new story * widths and vertical align * dynamic ellipsis * comment * combined components * cell generic type * update types * align styles * Prerelease version packages 13.0.0-beta.0 * fix install error * Prerelease version packages 13.0.0-beta.1 * comment, wip * revert useLeafyGreenTable hook so its consistent with a virtual table * add getItemKey * small fix * stop mapping columns def * testing * debugging * tbody updates * css vars * add virtual context * remove comment * remove measureElement from hook * row context updates * remove overflow from regular table * updates virtual types * more TS docs * ts fixes * row TS docs * TS docs stuff * fix comment * add react-intersection-observer * wip * remove original from rowCopy * story clean up * remove v10 and v11 adapter * remove react-virtual * cell styles * interrowwithRT style updates * table styles * comment * comment * wip * story with less rows * move box-shadow to headerRow * darken darkmode scroll shadow * move styles * add test * remove comments * testing removing styled components * add back styled * diff react-intersection-observer version * yarn lonk * cell ternary, headercell util, expandedcontent styles * fb - toggleExpand, isVirtual boolean, type casting, tsdocs * virtual scrolling padding util * forgot to save * fb - remove virtual context * custom row model * styledcomponent stuff, TS still not correct * callable virtual items * update ts docs * token * use classname * move interaction test * use a classname * remove id * remove ? * fix broken stories * interaction rename and args * story heights * add comment * add comment * revert changes to expandedContentParentStyles
* wip * wip * updating stories * lg virtual item * top styles * remove padding from TableBody * expanded row background color * removing stuff * row context * memoizing stuff * wip * styled components * comments * more cleanup * clean up * comments * wip, memoize regular table * testing * huh * why does this work? * testing why nothing works * clean up * update virtual stories * clean up * cleanup * row types * types * should truncate support * remove memo from useLeafyGreenVirtualTable * remove unsed exports * add a new story * widths and vertical align * dynamic ellipsis * comment * combined components * cell generic type * update types * align styles * Prerelease version packages 13.0.0-beta.0 * fix install error * Prerelease version packages 13.0.0-beta.1 * comment, wip * revert useLeafyGreenTable hook so its consistent with a virtual table * add getItemKey * small fix * stop mapping columns def * testing * debugging * tbody updates * css vars * add virtual context * remove comment * remove measureElement from hook * row context updates * remove overflow from regular table * updates virtual types * more TS docs * ts fixes * row TS docs * TS docs stuff * fix comment * add react-intersection-observer * wip * remove original from rowCopy * story clean up * remove v10 and v11 adapter * remove react-virtual * cell styles * interrowwithRT style updates * table styles * comment * comment * wip * story with less rows * move box-shadow to headerRow * darken darkmode scroll shadow * move styles * alignment * remove comment * add test * remove comments * testing removing styled components * add back styled * diff react-intersection-observer version * yarn lonk * cell ternary, headercell util, expandedcontent styles * fb - toggleExpand, isVirtual boolean, type casting, tsdocs * virtual scrolling padding util * forgot to save * fb - remove virtual context * custom row model * styledcomponent stuff, TS still not correct * callable virtual items * update ts docs * token * use classname * move interaction test * use a classname * remove id * remove ? * fix broken stories * interaction rename and args * story heights * add back color * update stories * remove InternalCell file * new story * fix row stories * update rows stories * revert some story changes * revert some more story changes * use classname * revert some story changes
* wip * wip * updating stories * lg virtual item * top styles * remove padding from TableBody * expanded row background color * removing stuff * row context * memoizing stuff * wip * styled components * comments * more cleanup * clean up * comments * wip, memoize regular table * testing * huh * why does this work? * testing why nothing works * clean up * update virtual stories * clean up * cleanup * row types * types * should truncate support * remove memo from useLeafyGreenVirtualTable * remove unsed exports * add a new story * widths and vertical align * dynamic ellipsis * comment * combined components * cell generic type * update types * align styles * Prerelease version packages 13.0.0-beta.0 * fix install error * Prerelease version packages 13.0.0-beta.1 * comment, wip * revert useLeafyGreenTable hook so its consistent with a virtual table * add getItemKey * small fix * stop mapping columns def * testing * debugging * tbody updates * css vars * add virtual context * remove comment * remove measureElement from hook * row context updates * remove overflow from regular table * updates virtual types * more TS docs * ts fixes * row TS docs * TS docs stuff * fix comment * add react-intersection-observer * wip * remove original from rowCopy * story clean up * remove v10 and v11 adapter * remove react-virtual * cell styles * interrowwithRT style updates * table styles * comment * comment * wip * story with less rows * move box-shadow to headerRow * darken darkmode scroll shadow * move styles * add test * remove comments * testing removing styled components * add back styled * diff react-intersection-observer version * yarn lonk * cell ternary, headercell util, expandedcontent styles * fb - toggleExpand, isVirtual boolean, type casting, tsdocs * virtual scrolling padding util * forgot to save * fb - remove virtual context * custom row model * styledcomponent stuff, TS still not correct * callable virtual items * update ts docs * token * use classname * move interaction test * use a classname * remove id * add table-layout:fixed * make table fixed, fix shadow and aligment * line height * remove ? * fix error * fix broken stories * interaction rename and args * story heights * revert row style changes * update sizes * add comment * update story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4146
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes