-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4356 reverse slack modal sort #990
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1c7e6c5
DOP-4356 reverse slack modal sort
anabellabuckvar 32f60db
DOP-4356 sort versions accurately
anabellabuckvar 1ae2db9
DOP-4356 sort versions accurately
anabellabuckvar 6c8b44b
DOP-4356 sort versions accurately
anabellabuckvar 66d78d6
DOP-4356 checking sorting again
anabellabuckvar 4c02be7
DOP-4356 sort before splice
anabellabuckvar 139d007
DOP-4356 just implement reverse and splice
anabellabuckvar 88f205b
DOP-4356 retrying sort accurately
anabellabuckvar ad6bd4f
DOP-4356 retrying sort accurately
anabellabuckvar 6dd843b
DOP-4356 trying other splicing
anabellabuckvar e87d10f
DOP-4356 update comments, remove from preprd
anabellabuckvar 920ddd3
Merge branch 'main' into DOP-4356
anabellabuckvar f65fcb0
DOP-4356 cleanup
anabellabuckvar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally using a sort method without a compare function makes me sweat but simply because Github enforces rules on owner names and repo names in respect to symbols, this is safe to me. I'm 99.99% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm ok, do you think I should add a sort function of some ~sort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be the very rare time when I say you don't have to 😆