[DOP-4170]: Create AWS ECS Task definition to process Snooty Parser cache updates #951
Conversation
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://l2yimj2j9d.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
branberry
changed the title
| @@ -1,6 +1,6 @@ | |||
| import { Duration } from 'aws-cdk-lib'; | |||
| import { Cors, CorsOptions, LambdaIntegration, LambdaRestApi } from 'aws-cdk-lib/aws-apigateway'; | |||
| import { Code, Function, Runtime } from 'aws-cdk-lib/aws-lambda'; | |||
| import { Code, DockerImageCode, DockerImageFunction, Function, Runtime } from 'aws-cdk-lib/aws-lambda'; | |||
There was a problem hiding this comment.
Are these new imports needed still? I believe they're unused.
| assumedBy: new ServicePrincipal('ecs-tasks.amazonaws.com'), | ||
| }); | ||
|
|
||
| const snootyParseCacheBucket = Bucket.fromBucketName(this, 'snooty-parse-cache', 'snooty-parse-cache'); |
There was a problem hiding this comment.
nit: Since snooty-parse-cache is already a constant here, should we change it to be a global variable we can utilize here? Not a blocker for merge.
There was a problem hiding this comment.
Hey Matt! I think this is a great suggestion, but I am running into issues when importing it here. I believe it has to do with the fact that the cdk-infra is a separate project from the root project, and this leads to funky behavior.
What I'll do is define the constant here, and add that as an environment variable 👍
Ticket
DOP-4170
Notes
This ticket implements the cache update worker via an ECS task. This ticket also contains additional updates to the
update-feature-branch.ymlworkflow to process jobs in parallel, as well as provide caching fornode_modulesbetween jobs.Spike document for context
Verification
Here is a link to the CloudWatch logs that show a successful job run.
Here is a link of the uploaded cache file for
docs-java.