Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Optional chaining to shortcircuit error with container #949

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mmeigs
Copy link
Contributor

@mmeigs mmeigs commented Dec 7, 2023

Just saw this error in Cloudwatch. Honestly not sure if this was from what I'm dealing with, but I found this in the code and thought it might be worth adding to make sure this kind of error doesn't occur.

Error seen in Cloudwatch:

    "errorType": "TypeError",
    "errorMessage": "Cannot read properties of undefined (reading 'lastStatus')",
    "stack": [
        "TypeError: Cannot read properties of undefined (reading 'lastStatus')",
        "    at ECSContainer.stopZombieECSTask (/var/task/api/controllers/v1/jobs.js:78232:25)",
        "    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)",
        "    at async stopECSTask (/var/task/api/controllers/v1/jobs.js:78815:3)",
        "    at async /var/task/api/controllers/v1/jobs.js:78761:15",
        "    at async Promise.all (index 0)",
        "    at async Runtime.HandleJobs [as handler] (/var/task/api/controllers/v1/jobs.js:78734:3)"
    ]
}

Link to Cloudwatch error

@mmeigs mmeigs requested a review from rayangler December 7, 2023 15:24
Copy link

github-actions bot commented Dec 7, 2023

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://gufltzpva6.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

Copy link
Contributor

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing!

@mmeigs mmeigs merged commit c2678e6 into master Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants