-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4073: Adding support for curling dependencies stored in repos_branches #946
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
cc745e8
working locally with hardcoded values
mayaraman19 ee70cf9
ading to github push
mayaraman19 e60c4f8
adding to build function
mayaraman19 2880e32
trying again
mayaraman19 af03f92
updating structure
mayaraman19 02a3f0a
editing errors
mayaraman19 2f7e349
fianlly curling
mayaraman19 0a3e5bc
curl errors
mayaraman19 4759edb
cleaning up
mayaraman19 5273873
changing structurea gain
mayaraman19 707e090
adding curl options
mayaraman19 60de805
testing removing from github.ts
mayaraman19 e3731d7
moving logic
mayaraman19 c4dbc63
cleaning up
mayaraman19 48ea293
fixing localapp error
mayaraman19 6b1c427
addressing comments and renaming buildDir to targetDir
mayaraman19 dff22d4
addressing comments part 2
mayaraman19 088b80b
Merge branch 'master' into DOP-4073
mayaraman19 8e0c8c9
debugging empty array
mayaraman19 20016ab
Merge branch 'DOP-4073' of https://github.com/mongodb/docs-worker-poo…
mayaraman19 1345027
debugging
mayaraman19 4e7eb13
debugging still
mayaraman19 5736908
adding try catch
mayaraman19 fe73f52
adding promise.all
mayaraman19 0f1b376
adding async
mayaraman19 5e87b6a
adding await
mayaraman19 5382aac
testing await
mayaraman19 50cd8f5
refining try-catch, adding await promise.all
mayaraman19 83f5e77
dependency info logging
mayaraman19 6afab31
Merge branch 'master' into DOP-4073
mayaraman19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,18 @@ export enum JobStatus { | |
// regression = 'regression', | ||
// } | ||
|
||
export type BuildDependencies = DependencyInfo[]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for adding these types! |
||
|
||
type Dependency = { | ||
url: string; | ||
filename: string; | ||
}; | ||
|
||
type DependencyInfo = { | ||
targetDir?: string; | ||
dependencies: Dependency[]; | ||
}; | ||
|
||
export type Payload = { | ||
jobType: string; | ||
source: string; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I think we should narrow this try/catch to cover where in the code an exception might be thrown i.e. we can wrap just the
executeCliCommand
calls with a try catch. This allows us to be more fine-grained in our errors. For example: