Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-4003]: Use custom webhook for initial feature branch deploy #941

Merged
merged 19 commits into from
Dec 1, 2023
Merged

[DOP-4003]: Use custom webhook for initial feature branch deploy #941

merged 19 commits into from
Dec 1, 2023

Conversation

branberry
Copy link
Contributor

@branberry branberry commented Nov 21, 2023 •
edited
Loading

Forgot to get reviews on this one! This PR introduces the new custom webhook for commenting on PRs.

@github-actions GitHub Actions
Copy link

The URL for your feature branch webhook is https://f1cqi8o3k3.execute-api.us-east-2.amazonaws.com/prod/

@github-actions GitHub Actions
Copy link

Your feature branch infrastructure has been deployed!
your webhook URL is: https://f1cqi8o3k3.execute-api.us-east-2.amazonaws.com/prod/

@github-actions GitHub Actions
Copy link

Your feature branch infrastructure has been deployed!
your webhook URL is: https://f1cqi8o3k3.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build
for more information on how to use this endpoint, follow these instructions

@branberry branberry mentioned this pull request Nov 22, 2023
Merged
@branberry branberry changed the title [DOP-4003]: Add test workflow [DOP-4003]: Use custom webhook for initial feature branch deploy Dec 1, 2023
mmeigs
mmeigs approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reminder to change or delete the "Example" section at the bottom of the Wiki page once this merges as it will be out of date!

@branberry branberry marked this pull request as ready for review December 1, 2023 16:12
@branberry
Copy link
Contributor Author

@mmeigs Done!

@branberry branberry merged commit 9a65a04 into master Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeigs mmeigs mmeigs approved these changes

@rayangler rayangler Awaiting requested review from rayangler

@seungpark seungpark Awaiting requested review from seungpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@branberry @mmeigs