DOP-4127: Monorepo builds without Makefiles #938

mmeigs · 2023-11-20T16:48:06Z

Ticket

Notes

The ticket was to build docs-monorepo/cloud-docs locally.
This PR actually encompasses building docs-monorepo/cloud-docs and docs-monorepo/docs-landing sites with the local debugger and also with github pushes. Probably half of this code is also merged with @branberry 's wonderful local debugger build capabilities. A real-life team PR in the flesh.

Note: as of now docs-monorepo/docs-mongodb-internal does build in development pretty well, but there's a bug with the newly-merged "curled" build dependencies. This will probably be settled in a future ticket unless I can figure it out soon!

Examples of builds and build logs

mmeigs/docs-monorepo/cloud-docs build log

gatsby preview link

To show no regressions when building a standard repo:
10gen/docs-node build log

gatsby preview link

Added Benchmarks back in to this process

src/commands/src/shared/next-gen-parse.ts

src/commands/src/shared/next-gen-stage.ts

src/commands/src/helpers/dependency-helpers.ts

src/job/stagingJobHandler.ts

src/job/jobHandler.ts

* [DOP-4204]: Add help command * [DOP-4204]: Typo * [DOP-4204]: Formatting * [DOP-4024]: Update README.md * [DOP-4204]: Troubleshooting * [DOP-4204]: Fix typos * [DOP-4204]: Rename images and move into shared folder * [DOP-4204]: Update troubleshooting

branberry

Hi Matt! Thank you for the last few adjustments. Just have a few more comments. Sorry to keep piling stuff on, but I believe we are really close to the finish line with this, thank you for all of your really quick responses!! I'll make sure to keep an eye on this.

src/job/jobHandler.ts

branberry

Hey Matt! Looks amazing. Did another pass through, and it looks good to me. Feel free to take your time double checking of course if you'd like before you merge. Also, I would feel comfortable with at least one other person approving.

Great work!!

Dockerfile.local

rayangler

Things generally lgtm!

README.md

Dockerfile.local

Co-authored-by: rayangler <[email protected]>

mmeigs added 30 commits November 14, 2023 15:50

experiments, added nextGenParse call to jobHandler

f4b5188

stage ecs - no makefiles

8f941ba

alter snooty version

706af67

next gen html

1a63501

command key

0be0b24

parse

6c43e45

catch

e733122

logger

2442b6f

remove error

901a229

more logging

9aa2fd2

cwd

8bd6ade

repoDir correct

c11687b

quotations

68eed83

successful parse? odd address

e9d9b36

oas page build

dc4c2a1

xlarge

1873ce9

persistence module

478ebf3

quote

ab4f652

no parse

71751a4

try catch parse

38c0f7d

type error

e313e5f

no parse, use persistence and build

b97835c

log errors

97cbc8b

localApp working

2832b0e

remove /dist

1d45d72

add build deps & nextgenhtml

11bac2c

add logging to build deps

7aee7af

log html

afadedc

remove build deps for envs

e320a67

env vars

178e680

mmeigs added 2 commits December 19, 2023 10:16

Merge branch 'master' into DOP-4127-no-makefiles

64e6af4

replace useWithBenchmarks with isNextGen

d1367a7

branberry reviewed Dec 19, 2023

View reviewed changes

src/commands/src/shared/next-gen-parse.ts Outdated Show resolved Hide resolved

mmeigs added 2 commits December 20, 2023 11:09

source patchId from getBuildAndGetDependencies

e16a789

Merge branch 'master' into DOP-4127-no-makefiles

ffe258c

branberry reviewed Jan 2, 2024

View reviewed changes

src/commands/src/shared/next-gen-stage.ts Outdated Show resolved Hide resolved

src/commands/src/helpers/dependency-helpers.ts Show resolved Hide resolved

src/job/stagingJobHandler.ts Show resolved Hide resolved

src/job/jobHandler.ts Show resolved Hide resolved

branberry and others added 3 commits January 2, 2024 14:12

added logging and error throwing in wrapWithBenchmark

f7d968f

conditionally write patchId and commitHash env vars

8e5e756

mmeigs requested review from rayangler and branberry January 3, 2024 16:20

branberry reviewed Jan 3, 2024

View reviewed changes

src/job/jobHandler.ts Outdated Show resolved Hide resolved

src/job/jobHandler.ts Outdated Show resolved Hide resolved

mmeigs and others added 3 commits January 3, 2024 12:58

remove logger as parameter of wrapWithBenchmarks

4a790f3

[DOP-4127]: Update error logging and other misc changes

82f9024

[DOP-4127]: Fix tests

99bd05f

branberry approved these changes Jan 3, 2024

View reviewed changes

mmeigs commented Jan 4, 2024

View reviewed changes

Dockerfile.local Outdated Show resolved Hide resolved

rayangler approved these changes Jan 4, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Dockerfile.local Outdated Show resolved Hide resolved

rayangler reviewed Jan 4, 2024

View reviewed changes

Dockerfile.local Outdated Show resolved Hide resolved

branberry and others added 10 commits January 4, 2024 15:34

[DOP-4127]: Fix up localbuild (hopefully)

6ff805f

small clean-up changes

c18be50

clean

eb872da

dockerfile misspelling

2f95a05

[DOP-4127]: Fix up localbuild oas-page-builder

1e8e9a5

[DOP-4127]: Fix up localbuild

7002c09

[DOP-4127]: Fix readme error

3e34317

preprd

6d777ff

Update README.md

a9c96eb

Co-authored-by: rayangler <[email protected]>

remove preprd

c679c3f

mmeigs merged commit d5194e9 into master Jan 8, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOP-4127: Monorepo builds without Makefiles #938

DOP-4127: Monorepo builds without Makefiles #938

mmeigs commented Nov 20, 2023 •

edited

Loading

branberry left a comment

branberry left a comment

rayangler left a comment •

edited

Loading

DOP-4127: Monorepo builds without Makefiles #938

DOP-4127: Monorepo builds without Makefiles #938

Conversation

mmeigs commented Nov 20, 2023 • edited Loading

Ticket

Notes

Examples of builds and build logs

Added Benchmarks back in to this process

branberry left a comment

Choose a reason for hiding this comment

branberry left a comment

Choose a reason for hiding this comment

rayangler left a comment • edited Loading

Choose a reason for hiding this comment

mmeigs commented Nov 20, 2023 •

edited

Loading

rayangler left a comment •

edited

Loading