Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-3723: Use Autobuilder job id as persistence module build id #913

Merged
merged 11 commits into from
Sep 28, 2023

Conversation

rayangler
Copy link
Contributor

@rayangler rayangler commented Sep 21, 2023

Ticket

DOP-3723

Notes

  • Passes Autobuilder job ID to the persistence module so that build artifacts can be associated with a single build. By default or when the job ID argument is false-y, the persistence module will generate its own build ID like it currently does.
  • When there are updates to an updated_document, the build ID that triggered the update will be added to the document. This should help with increased observability of document updates.
  • Related Makefile change can be found at DOP-3723: Pass Autobuilder job ID to persistence module #915.
  • See job ID passed to the persistence module in this build log. Related screenshot with the same build ID in updated_documents can be found below.
Screen Shot 2023-09-22 at 2 16 03 PM

@github-actions
Copy link

The URL for your feature branch webhook is https://hgybtrdlaa.execute-api.us-east-2.amazonaws.com/prod/

Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes LGTM

two questions:

  • when are we reading for updated_pages.job_id, and should we be indexing this new field for any performance gains?
  • seems like the pages.test has been outdated but still passing? ie. _updatedPages takes in 4 args, 2 are defined in tests

@rayangler
Copy link
Contributor Author

@seungpark

when are we reading for updated_pages.job_id, and should we be indexing this new field for any performance gains?

The field may be useful for @schmalliso's metrics for Gatsby Cloud builds to see which Autobuilder job last updated a page. I would be down to add an index once the field is in use.

seems like the pages.test has been outdated but still passing? ie. _updatedPages takes in 4 args, 2 are defined in tests

Wow, thanks for catching this! I updated the tests accordingly

@rayangler rayangler merged commit 6d1dce2 into master Sep 28, 2023
7 checks passed
@rayangler rayangler deleted the DOP-3723 branch September 28, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants