-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-3723: Use Autobuilder job id as persistence module build id #913
Conversation
The URL for your feature branch webhook is https://hgybtrdlaa.execute-api.us-east-2.amazonaws.com/prod/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes LGTM
two questions:
- when are we reading for
updated_pages.job_id
, and should we be indexing this new field for any performance gains? - seems like the pages.test has been outdated but still passing? ie.
_updatedPages
takes in 4 args, 2 are defined in tests
The field may be useful for @schmalliso's metrics for Gatsby Cloud builds to see which Autobuilder job last updated a page. I would be down to add an index once the field is in use.
Wow, thanks for catching this! I updated the tests accordingly |
Ticket
DOP-3723
Notes
updated_document
, the build ID that triggered the update will be added to the document. This should help with increased observability of document updates.updated_documents
can be found below.