Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4020: repos_branches to docsets #909
DOP-4020: repos_branches to docsets #909
Changes from 22 commits
3f27242
8d53507
8216fd2
2dfc6bd
42b70f0
eeed174
763f2c6
776e30f
22b977c
5317f13
f96335d
3909513
5dbe09f
ea80698
4cf61c0
8269fe0
0cff1a1
01200c2
8352898
e6f8bf4
b002f2e
2b3a87a
fc45dff
e2ca1d4
b59e573
6d1e6d6
4727b68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 10 in api/controllers/v1/github.ts
GitHub Actions / test
Check warning on line 59 in api/controllers/v1/github.ts
GitHub Actions / test
Check warning on line 59 in api/controllers/v1/github.ts
GitHub Actions / test
Check warning on line 59 in api/controllers/v1/github.ts
GitHub Actions / test
Check warning on line 59 in api/controllers/v1/github.ts
GitHub Actions / test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are querying for
getRepo
twice (here and ingetRepoBranchesByRepoName
) can pass the repoInfo as a paramThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, done!
Check warning on line 16 in api/controllers/v1/jobs.ts
GitHub Actions / test
Check warning on line 16 in api/controllers/v1/jobs.ts
GitHub Actions / test
Check warning on line 16 in api/controllers/v1/jobs.ts
GitHub Actions / test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized these functions were identical and duplicated between v1 and v2. Rolled them out to a handlers file same as others we've done in the past month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more time here for double fetching
getRepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed! tysm