Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4669: add env var for enabling dark mode #1047

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

seungpark
Copy link
Contributor

Stories/Links:

DOP-4669

This PR adds logic to fetch AWS SM Param Store variables and use it to populate environment variables in the autobuilder + snooty front end

Notes

  • These key/values have been added to the param store manually in S3, with dotcomprd and prd values being false as described in ticket

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@seungpark seungpark marked this pull request as ready for review May 24, 2024 14:28
@mayaraman19
Copy link
Contributor

just to clarify - when GATSBY_ENABLE_DARK_MODE is true, does this mean dark mode is on or that the toggle is visible?

Copy link

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://3x7yqurv00.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

@seungpark
Copy link
Contributor Author

just to clarify - when GATSBY_ENABLE_DARK_MODE is true, does this mean dark mode is on or that the toggle is visible?

this means that the ability to turn on dark mode should be enabled on the front end :D this does not turn on dark mode automatically

Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Seung! Just one small comment

src/job/jobHandler.ts Show resolved Hide resolved
@branberry branberry self-requested a review May 24, 2024 19:46
Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind, I'll approve it because my comment is really minor. Everything else looks good!

@seungpark seungpark merged commit 71b64c1 into main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants