-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4571: migration script for bad repo branches #1037
base: main
Are you sure you want to change the base?
Conversation
Your feature branch infrastructure has been deployed! Your webhook URL is: https://awvmwd9xu9.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
@@ -8,7 +8,7 @@ import { ObjectId, Db, Document } from 'mongodb'; | |||
import { db as poolDb } from './pool'; | |||
|
|||
// We should only ever have one client active at a time. | |||
const atlasURL = `mongodb+srv://${process.env.MONGO_ATLAS_USERNAME}:${process.env.MONGO_ATLAS_PASSWORD}@${process.env.MONGO_ATLAS_HOST}/?retryWrites=true&w=majority&maxPoolSize=20`; | |||
const atlasURL = `mongodb://${process.env.MONGO_ATLAS_HOST}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change was for local dev. not important :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Can also exist in snooty-scripts if there's value in keeping this long-term
I'll leave this branch open after closing PR (without merge). snooty scripts did not have any dependencies or env setup but it will be good to have for future migrations. Dropping in a ticket for setting up the overhead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
ran in pool and pool_test (repos_branches collections) IN pool_test.repos_branches
|
Stories/Links:
DOP-4571
Notes
pool.repos_branches
for bad branch valuesmaster
branches will be pushed tomongodb.com/docs/{prefix}/master
with this change, but this line seems safe