-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-4438]: Add component filtering for production builds in the Autobuilder #1025
Changes from 9 commits
e1fa743
dbe22d5
a0de4df
25d363b
6f9095f
ea5d49c
a95d16f
4860532
5e0b85c
eed770c
572bc8d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,12 +166,6 @@ describe('ProductionJobHandler Tests', () => { | |
jobHandlerTestHelper.setupForSuccess(); | ||
await jobHandlerTestHelper.jobHandler.execute(); | ||
jobHandlerTestHelper.verifyNextGenSuccess(); | ||
// TODO: Correct number of arguments | ||
expect(jobHandlerTestHelper.fileSystemServices.writeToFile).toBeCalledWith( | ||
`repos/${jobHandlerTestHelper.job.payload.repoName}/.env.production`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed this as I believe it's not providing a ton of value, and leads to additional overhead when making changes. |
||
TestDataProvider.getEnvVarsWithPathPrefixWithFlags(jobHandlerTestHelper.job), | ||
{ encoding: 'utf8', flag: 'w' } | ||
); | ||
}); | ||
|
||
test('Default production deploy does not kick off manifest generation', async () => { | ||
|
@@ -244,12 +238,6 @@ describe('ProductionJobHandler Tests', () => { | |
jobHandlerTestHelper.setupForSuccess(); | ||
await jobHandlerTestHelper.jobHandler.execute(); | ||
jobHandlerTestHelper.verifyNextGenSuccess(); | ||
|
||
expect(jobHandlerTestHelper.fileSystemServices.writeToFile).toBeCalledWith( | ||
`repos/${jobHandlerTestHelper.job.payload.repoName}/.env.production`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed this as I believe it's not providing a ton of value, and leads to additional overhead when making changes. |
||
`GATSBY_PARSER_USER=TestUser\nGATSBY_PARSER_BRANCH=${jobHandlerTestHelper.job.payload.branchName}\nPATH_PREFIX=/\nGATSBY_BASE_URL=test\nPREVIEW_BUILD_ENABLED=false\nGATSBY_TEST_SEARCH_UI=false\nGATSBY_HIDE_UNIFIED_FOOTER_LOCALE=true\nGATSBY_MARIAN_URL=test-url\n`, | ||
{ encoding: 'utf8', flag: 'w' } | ||
); | ||
}); | ||
|
||
test('Execute Next Gen Build successfully', async () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove omit dev as the filter functionality for the frontend depends on a dev dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why it's a dev dependency then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question! We should definitely consider moving the relevant dependencies to be installed for prod in the near future if possible