Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ DOP-4240 implements filtering sensitive values method to prevent sensitive values being logged #1012

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

caesarbell
Copy link
Collaborator

Stories/Links:

DOP-4240

Notes

Context: The code changes provided add a filtering method that looks for sensitive values from our param store, and redacts any sensitive values found in the message that is being logged.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

github-actions bot commented Mar 7, 2024

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://ofk9zlrpk1.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

Copy link
Contributor

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I would wait to merge until Brandon reviews, in case he has any important insight

src/enhanced/utils/get-sensitive-values.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caesarbell caesarbell merged commit 6800a4f into main Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants