Skip to content

Commit

Permalink
DOP-4414 removing more env vars
Browse files Browse the repository at this point in the history
  • Loading branch information
anabellabuckvar committed Mar 25, 2024
1 parent 7d1a06f commit 8e39c0b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
9 changes: 3 additions & 6 deletions api/controllers/v2/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,14 @@ export const triggerSmokeTestAutomatedBuild = async (event: APIGatewayEvent): Pr
return {
statusCode: 202,
headers: { 'Content-Type': 'text/plain' },
body: `Build on branch
${body.workflow_run.head_branch}
is not complete and will not trigger smoke test site deployments`,
body: `Build on branch ${body.workflow_run.head_branch} is not complete and will not trigger smoke test site deployments`,
};

if (body.workflow_run.name != 'Deploy Staging ECS')
return {
statusCode: 202,
headers: { 'Content-Type': 'text/plain' },
body: `Workflow
${body.workflow_run.name} completed successfully but only Deploy Staging ECS workflow completion will trigger smoke test site deployments`,
body: `Workflow ${body.workflow_run.name} completed successfully but only Deploy Staging ECS workflow completion will trigger smoke test site deployments`,
};

// if the build was not building main branch, no need for smoke test sites
Expand Down Expand Up @@ -244,7 +241,7 @@ export const triggerSmokeTestAutomatedBuild = async (event: APIGatewayEvent): Pr
return {
statusCode: 202,
headers: { 'Content-Type': 'text/plain' },
body: 'Smoke Test Jobs Queued with the following Job Ids' + returnVal,
body: 'Smoke Test Jobs Queued with the following Job Ids ' + returnVal,
};
};

Expand Down
1 change: 0 additions & 1 deletion cdk-infra/static/api/config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"entitlementCollection": "USER_ENTITLEMENT_COL_NAME",
"repoBranchesCollection": "REPO_BRANCHES_COL_NAME",
"docsetsCollection": "DOCSETS_COL_NAME",
"projectsCollection": "PROJECTS_COL_NAME",
"MONGO_TIMEOUT_S": 15,
"JOB_TIMEOUT_S": 900,
"RETRY_TIMEOUT_MS": 5000,
Expand Down
1 change: 0 additions & 1 deletion config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"githubBotPW": "q1w",
"fastlyDochubMap": "devfslydochubmap",
"entitlementCollection": "entitlements",
"projectsCollection": "projects",
"docsetsCollection": "docsets",
"MONGO_TIMEOUT_S": 1500,
"JOB_TIMEOUT_S": 900,
Expand Down

0 comments on commit 8e39c0b

Please sign in to comment.