[DOP-4171]: Warn instead of throw error on getSnootyParserVersion

mongodb · Jan 26, 2024 · 886438e · 886438e
1 parent a3c52be
commit 886438e
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/.github/workflows/deploy-feature-branch.yml b/.github/workflows/deploy-feature-branch.yml
@@ -21,23 +21,27 @@ jobs:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: us-east-2
-      - name: Deploy Feature Branch Infrastructure
+
+      - name: Install Node Dependencies
         run: |
           npm ci
           cd cdk-infra/
           npm ci
-          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-queues
-          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-worker
-          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-webhooks --outputs-file outputs.json
-      - name: Get Webhook URL 
-        uses: mongodb/docs-worker-actions/comment-pr@main
-        env: 
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Cache root node_modules
         id: cache-root
         uses: actions/cache@v3
         with:
           path: |
             node_modules
             cdk-infra/node_modules
-          key: ${{ github.head_ref }}
+          key: ${{ github.head_ref }}
+      - name: Deploy Feature Branch Infrastructure
+        run: |
+          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-queues
+          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-worker
+          npm run deploy:feature:stack -- -c env=stg -c customFeatureName=enhancedApp-stg-${{github.head_ref}} auto-builder-stack-enhancedApp-stg-${{github.head_ref}}-webhooks --outputs-file outputs.json
+      - name: Get Webhook URL 
+        uses: mongodb/docs-worker-actions/comment-pr@main
+        env: 
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/test-cache-updater.yml b/.github/workflows/test-cache-updater.yml
@@ -20,7 +20,7 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: us-east-2
 
-      - name: Get Webhook URL 
+      - name: Rebuild Cache if New Snooty Parser Version
         uses: mongodb/docs-worker-actions/rebuild-parse-cache@DOP-4294
         env: 
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/cdk-infra/utils/env.ts b/cdk-infra/utils/env.ts
@@ -80,7 +80,11 @@ export function isEnhanced(): boolean {
 export function getSnootyParserVersion(): string {
   checkContextInit();
   const snootyParserVersion = contextVarsMap.get('snootyParserVersion');
-  if (!snootyParserVersion) throw new Error('Error! The context variable snootyParserVersion is not defined.');
+
+  if (!snootyParserVersion) {
+    console.warn('Error! The context variable snootyParserVersion is not defined.');
+    return '';
+  }
 
   return snootyParserVersion;
 }