DOP-4724 cleaning up

mongodb · Jan 18, 2024 · 69e3c94 · 69e3c94
1 parent 6a62ff7
commit 69e3c94
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/api/handlers/slack.ts b/api/handlers/slack.ts
@@ -24,18 +24,15 @@ export async function buildEntitledBranchList(entitlement: any, repoBranchesRepo
     const [repoOwner, repoName, directoryPath] = repo.split('/');
     const branches = await repoBranchesRepository.getRepoBranches(repoName, directoryPath);
     for (const branch of branches) {
-      if ('buildsWithSnooty' in branch) {
-        const buildWithSnooty = branch['buildsWithSnooty'];
-        if (buildWithSnooty) {
-          const active = branch['active'];
-          const repoPath = `${repoOwner}/${repoName}${directoryPath ? '/' + directoryPath : ''}/${
-            branch['gitBranchName']
-          }`;
-          if (!active) {
-            entitledBranches.push(`!inactive ` + `${repoPath}`);
-          } else {
-            entitledBranches.push(repoPath);
-          }
+      if ('buildWithSnooty' in branch && branch['buildsWithSnooty']) {
+        const active = branch['active'];
+        const repoPath = `${repoOwner}/${repoName}${directoryPath ? '/' + directoryPath : ''}/${
+          branch['gitBranchName']
+        }`;
+        if (!active) {
+          entitledBranches.push(`!inactive ` + `${repoPath}`);
+        } else {
+          entitledBranches.push(repoPath);
         }
       }
     }

diff --git a/src/services/slack.ts b/src/services/slack.ts
@@ -140,7 +140,7 @@ export class SlackConnector implements ISlackConnector {
               action_id: 'repo_option',
               placeholder: {
                 type: 'plain_text',
-                text: 'deploy',
+                text: 'Select a repo to deploy',
                 emoji: true,
               },
               options: repos,