DOP-4831: Save Lighthouse HTML reports to S3 (rather than Atlas) #84
+49,550
−2,436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branberry
reviewed
Jul 19, 2024
seungpark
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Storing these HTML strings and JSON results in Atlas is much too large and unnecessary.
This PR does away with storing the JSON results completely, and now stores the HTML reports in S3 in a new bucket
docs-lighthouse.Also, now that the code has become larger, I've split the action into separate files to more coherently organize it. Ideally it's clearer now.
Notes
I'm opening a PR in Snooty to ensure that the AWS credentials will be setup before the action for a successful upload. That will be merged before this.
I have already deleted the jsonRuns within Atlas currently. This has made queries much faster already. Also, once this is merged, I will once again delete whatever jsonRuns still remain, and I will create a script to upload all htmlRuns correctly to S3 and then delete them from Atlas.
Examples
Link to S3 bucket
Link to Snooty PR