-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-4003]: Refactor GitHub commenter to custom action #48
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
12f5667
[DOP-4003]: Modify build
branberry 6b803b4
[DOP-4003]: Run action
branberry 9990008
[DOP-4003]: Move stuff around for testing
branberry 4e9a904
[DOP-4003]: Move stuff around for testing
branberry 4b8cd48
[DOP-4003]: Update dependencies
branberry a41665b
[DOP-4003]: Import context directly
branberry 54a890a
[DOP-4003]: Update bundle
branberry 8cf4b8f
[DOP-4003]: Update bundle
branberry dda1211
[DOP-4003]: Use correct token name
branberry fdccbbe
[DOP-4003]: Add bundle
branberry 1ce4ffa
[DOP-4003]: Add logging for context and outputs
branberry 884f646
[DOP-4003]: Add logging for context and outputs
branberry 43ede22
[DOP-4003]: Add logging for context and outputs
branberry e1c5369
[DOP-4003]: Use correct environment variable for head_ref
branberry c296524
[DOP-4003]: Add path for the github trigger build endpoint
branberry f33ebfd
[DOP-4003]: Include instructions with GitHub bot message
branberry 302ec23
[DOP-4003]: Small grammar change
branberry 8081279
[DOP-4003]: Format the message a bit more nicely
branberry 8d3d990
[DOP-4003]: Update linting and add simple test
branberry 599657c
[DOP-4003]: Add run.ts
branberry 99153b5
[DOP-4003]: Remove local test for now
branberry 4abb9e5
[DOP-4003]: Disable linting rule
branberry 1ef8ba3
[DOP-4003]: Remove pointless and annoying super linter
branberry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { run } from '../src/comment-pr/run'; | ||
|
||
// Mock the action's entrypoint | ||
jest.mock('../src/comment-pr/run', () => ({ | ||
run: jest.fn() | ||
})); | ||
|
||
describe('index', () => { | ||
it('calls run when imported', async () => { | ||
require('../src/comment-pr'); | ||
|
||
expect(run).toHaveBeenCalled(); | ||
}); | ||
}); |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this is re-inserted after this PR is merged (post creating an action as per docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seungpark I actually removed it because the CI will always fail here because this action depends on another step. I guess I could refactor it so that it would be easier to use the output from a previous step, but it reads a file and I am not sure of a way to do that using inputs/outputs.
I will make another story to get integration testing working again. For the time being, I am disabling this step.