Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-37239: Upgrade to Dart v2.0.0 #3208

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

cbullinger
Copy link
Collaborator

@cbullinger cbullinger commented Mar 21, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-37239

  • Flutter SDK: Regenerate snippets with .realm.dart part files, and update part directives to point to new file extension
  • Test suite: Upgrade to Dart SDK v2.0.0

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • [n/a] Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • Flutter SDK
    • Update Bluehawked code snippets throughout docs to use the new .realm.dart part file extension.

Review Guidelines

REVIEWING.md

@@ -2,6 +2,5 @@
class _BinaryExample {
late String name;
late Uint8List requiredBinaryProperty;
var defaultValueBinaryProperty = Uint8List(8);
Copy link
Collaborator Author

@cbullinger cbullinger Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since initializing with a non-constant expression shouldn't have been allowed; was "fixed" in this release.

@cbullinger cbullinger changed the base branch from dart-v2.0.0 to master March 21, 2024 13:03
@cbullinger cbullinger force-pushed the docsp-37239-upgrade-dart branch from e43a49f to 734d259 Compare March 21, 2024 13:06
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbullinger cbullinger merged commit ee0c65b into mongodb:master Mar 21, 2024
5 checks passed
@cbullinger cbullinger deleted the docsp-37239-upgrade-dart branch March 21, 2024 13:26
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants