Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-35099): Flutter: fix failing unit tests #3123

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

dacharyc
Copy link
Collaborator

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-35099

The remaining failing test is in manage_sync_session_test.dart, which Kyle modified and may have fixed in #3122 ?

Release Notes

  • Flutter SDK
    • Internal: Fix failing code example tests related to SDK changes.

Review Guidelines

REVIEWING.md

Copy link

Readability for Commit Hash: edf7d2e

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/flutter/sync/write-to-synced-realm: Grade Level: 11.3, Reading Ease: 50.67

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up these tests, Dachary! LGTM.

@dacharyc dacharyc merged commit 8fafa78 into mongodb:master Dec 21, 2023
6 checks passed
@dacharyc dacharyc deleted the DOCSP-35099 branch December 21, 2023 16:27
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants