-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-34055): Swift: Add docs for wait for upload/download #3076
Conversation
Readability for Commit Hash: 98634c9 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
26c0063
to
7681716
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, LGTM!
|
||
You can use these methods with Swift's async/await syntax, or with the | ||
callback syntax. The callback version can take a queue to dispatch the | ||
callback onto, and a block to invoke when waiting is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callback onto, and a block to invoke when waiting is complete. | |
and a block to invoke when waiting is complete. |
|
||
You can use these methods with Swift's async/await syntax, or with the | ||
callback syntax. The callback version can take a queue to dispatch the | ||
callback onto, and a block to invoke when waiting is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callback onto, and a block to invoke when waiting is complete. | |
and a block to invoke when waiting is complete. |
``realm.syncSession?.wait(for: .download)``. | ||
|
||
You can use these methods with Swift's async/await syntax, or with the | ||
callback syntax. The callback version can take a queue to dispatch the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callback syntax. The callback version can take a queue to dispatch the | |
callback syntax. The callback version can take a queue for callbacks |
Optional edit for clarity, continued in next comment. Think "queue to dispatch the callback onto" is unnecessarily complex.
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/master/ 🪵 Logs |
Pull Request Info
While the eng PR this documents has been merged to master, it is not yet released. Wait for the next release before publishing. Before publishing:
Jira
Staged Changes
Reminder Checklist
If your PR modifies the docs, you might need to also update some corresponding
pages. Check if completed or N/A.
Release Notes
Review Guidelines
REVIEWING.md