Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evergreen patch build link #44

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 24, 2024

@blink1073 blink1073 requested a review from alcaeus June 24, 2024 16:14
@blink1073 blink1073 marked this pull request as ready for review June 24, 2024 16:27
@blink1073 blink1073 requested a review from baileympearson June 24, 2024 17:22
@blink1073 blink1073 mentioned this pull request Jun 24, 2024
Copy link
Collaborator

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem correct but I get a 404 when I attempt to visit the generated URL (I got it from the uploaded security report in s3). It's possible I just don't have permissions to view this patch. Did you confirm the generated URL is correct? @blink1073

@blink1073
Copy link
Member Author

I ran it from my fork, which doesn't produce EVG patches. We'll just have to wait and see. 😄

Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct. I also confirmed that the URI that would've been generated for one of the last PHP releases is actually valid.

@blink1073 blink1073 merged commit b9f555b into mongodb-labs:main Jun 25, 2024
3 checks passed
@blink1073 blink1073 deleted the add-evergreen-link branch June 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants