Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install PHP dependencies in the project #213

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Install PHP dependencies in the project #213

merged 1 commit into from
Sep 16, 2024

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Sep 13, 2024 •
edited
Loading

Fix PHP tests broken by mongodb/mongo-php-library#1395

Instead of duplicating parts of the composer.json from the library, the dependencies are installed in the library directly.

@GromNaN GromNaN requested a review from alcaeus September 13, 2024 09:10
alcaeus
alcaeus reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - if the validate-workload-executor tasks completes successfully we can schedule a couple of the actual tests for PHP to see if everything works correctly.

@GromNaN
Copy link
Contributor Author

GromNaN commented Sep 13, 2024

Test successful for PHP.

alcaeus
alcaeus approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested one test each on Atlas and Kind, both of which succeeded. Good to merge 👍

@alcaeus alcaeus marked this pull request as ready for review September 16, 2024 07:12
@alcaeus alcaeus merged commit 784b9e5 into main Sep 16, 2024
9 of 22 checks passed
@alcaeus alcaeus deleted the php-project-vendors branch September 16, 2024 07:13
Jibola pushed a commit to Jibola/drivers-atlas-testing that referenced this pull request Oct 17, 2024
@GromNaN @Jibola
Install PHP dependencies in the project (mongodb-labs#213)
75ef77b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus