feat: add analyzeDocuments + SchemaAccessor COMPASS-8799 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
COMPASS-8799
branch
from
c6196fc to
1249f8b
Compare
paula-stacho
changed the title
Anemy
reviewed
Jan 17, 2025
addaleax
reviewed
Jan 20, 2025
paula-stacho
changed the base branch from
main
to
COMPASS-6862-schema-export-multiple-formats
paula-stacho
force-pushed
the
COMPASS-8799
branch
from
f0119b9 to
f25238d
Compare
Anemy
approved these changes
Jan 21, 2025
addaleax
reviewed
Jan 21, 2025
src/schema-accessor.ts
Outdated
Comment on lines
47
to
48
| if (this.extendedJSONSchema) return this.extendedJSONSchema; | ||
| return this.extendedJSONSchema = await convertors.internalSchemaToExtended(this.internalSchema, options); |
There was a problem hiding this comment.
Just a suggestion, but these could all be e.g.
Suggested change
| if (this.extendedJSONSchema) return this.extendedJSONSchema; | |
| return this.extendedJSONSchema = await convertors.internalSchemaToExtended(this.internalSchema, options); | |
| return this.extendedJSONSchema ??= await convertors.internalSchemaToExtended(this.internalSchema, options); |
right?
There was a problem hiding this comment.
right, I keep forgetting this exists. thank you!
Co-authored-by: Anna Henningsen <[email protected]>
paula-stacho
merged commit 591fa39
into
COMPASS-6862-schema-export-multiple-formats
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
analyzeDocuments() -> SchemaAccessoras prep for having multiple formats. The interface has been chosen so that:see the tech design for more details.