Refs #26007 -- Improved the ImproperlyConfigured error message for Si…

…ngleObjectTemplateResponseMixin.get_template_names().
monetate · Dec 18, 2024 · 3ee4c6a · 3ee4c6a
1 parent 0fc6d53
commit 3ee4c6a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/django/views/generic/detail.py b/django/views/generic/detail.py
@@ -171,7 +171,11 @@ def get_template_names(self):
             # If we still haven't managed to find any template names, we should
             # re-raise the ImproperlyConfigured to alert the user.
             if not names:
-                raise
+                raise ImproperlyConfigured(
+                    "SingleObjectTemplateResponseMixin requires a definition "
+                    "of 'template_name', 'template_name_field', or 'model'; "
+                    "or an implementation of 'get_template_names()'."
+                )
 
         return names
 

diff --git a/tests/generic_views/test_base.py b/tests/generic_views/test_base.py
@@ -607,8 +607,9 @@ def test_template_mixin_without_template(self):
         """
         view = views.TemplateResponseWithoutTemplate()
         msg = (
-            "TemplateResponseMixin requires either a definition of "
-            "'template_name' or an implementation of 'get_template_names()'"
+            "SingleObjectTemplateResponseMixin requires a definition "
+            "of 'template_name', 'template_name_field', or 'model'; "
+            "or an implementation of 'get_template_names()'."
         )
         with self.assertRaisesMessage(ImproperlyConfigured, msg):
             view.get_template_names()