Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use GOMEMLIMIT for scanning Pods #1138

Merged
merged 1 commit into from
Jun 25, 2024
Merged

✨ Use GOMEMLIMIT for scanning Pods #1138

merged 1 commit into from
Jun 25, 2024

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jun 25, 2024

This should further help reduce OOMkills for the modified Pods.

This is the official doc for this: https://go.dev/doc/gc-guide#Suggested_uses

An example of another software using this: https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-production#setting-soft-memory-limits-on-dapr-sidecar

@github-actions GitHub Actions
Copy link

Test Results

  5 files  +  5   51 suites  +51   2h 24m 43s ⏱️ + 2h 24m 43s
316 tests +316  316 ✅ +316  0 💤 ±0  0 ❌ ±0 
385 runs  +385  385 ✅ +385  0 💤 ±0  0 ❌ ±0 

Results for commit 41b4601. ± Comparison against base commit f4e6f9e.

@czunker czunker marked this pull request as ready for review June 25, 2024 12:05
@czunker czunker merged commit f3d4113 into main Jun 25, 2024
21 checks passed
@czunker czunker deleted the czunker/GOMEMLIMIT branch June 25, 2024 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imilchev imilchev imilchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czunker @imilchev