🚀11.3.0 #1137
Merged
🚀11.3.0 #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imilchev
reviewed
Jun 24, 2024
There was a problem hiding this comment.
I believe we never commit the -z files. @czunker can you confirm?
There was a problem hiding this comment.
I even see them for the first time.
So, no we didn't commit them.
| {{- include "mondoo-operator.selectorLabels" . | nindent 6 }} | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: mondoo-operator |
There was a problem hiding this comment.
Can we keep this one? I thought we had to remove it
There was a problem hiding this comment.
yup, I can confirm, these should be gone. I don't have them when I generate the release. Perhaps you missed to change some sed to gsed?
There was a problem hiding this comment.
Here is the command which should remove it: https://github.com/mondoohq/mondoo-operator/blob/main/Makefile#L372
czunker
approved these changes
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.