Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove scope from gcp urls #3727

Merged
merged 1 commit into from
Apr 8, 2024
Merged

🧹 Remove scope from gcp urls #3727

merged 1 commit into from
Apr 8, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Apr 8, 2024

The format is now "/gcp/projectid/servicename/...". Project resources get a special "servicename" call "project"

The format is now "/gcp/projectid/servicename/...".
Project resources get a special "servicename" call "project"
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Test Results

2 967 tests  ±0   2 966 ✅ ±0   1m 15s ⏱️ -2s
  328 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit 3a9e795. ± Comparison against base commit 6c69a57.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jaym

@chris-rock chris-rock merged commit b0ec569 into main Apr 8, 2024
15 checks passed
@chris-rock chris-rock deleted the jdm/change-gcp-urls branch April 8, 2024 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants