Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix docker image scan for remote images #3646

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

imilchev
Copy link
Member

makes sure we can scan docker images that aren't present locally

Copy link
Contributor

Test Results

2 858 tests  ±0   2 857 ✅ ±0   1m 24s ⏱️ +7s
  187 suites ±0       1 💤 ±0 
    4 files   ±0       0 ❌ ±0 

Results for commit 43cdda4. ± Comparison against base commit a3d125d.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-21_19:47:06.01045506_+0000_UTC_m=+0.007618201
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-21_19:47:06.01045506_+0000_UTC_m=+0.007618201
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-21_19:47:06.01045506_+0000_UTC_m=+0.007618201#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-21_20:06:36.651389153_+0000_UTC_m=+0.010876227
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-21_20:06:36.651389153_+0000_UTC_m=+0.010876227
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-21_20:06:36.651389153_+0000_UTC_m=+0.010876227#01

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thank you @imilchev

@chris-rock chris-rock merged commit 1d86261 into main Mar 26, 2024
14 checks passed
@chris-rock chris-rock deleted the ivan/docker-image-scan branch March 26, 2024 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants