Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add isLastBatch to StoreResults #3508

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Mar 6, 2024

I see that we never implemented pushing data upstream but I still want to have the flag added for whenever we implement that

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Test Results

2 849 tests  ±0   2 848 ✅ ±0   1m 29s ⏱️ +8s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 203dcc2. ± Comparison against base commit 7f2f837.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-06_11:25:31.448606923_+0000_UTC_m=+0.015129017
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_11:25:31.448606923_+0000_UTC_m=+0.015129017
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_11:25:31.448606923_+0000_UTC_m=+0.015129017#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732#01

♻️ This comment has been updated with latest results.

@imilchev imilchev force-pushed the ivan/store-results-last-batch branch from 3b7f86f to 203dcc2 Compare March 6, 2024 13:22
@imilchev imilchev merged commit 54e3819 into main Mar 7, 2024
14 checks passed
@imilchev imilchev deleted the ivan/store-results-last-batch branch March 7, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants