Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐ add typemaps for simple types #3463

Merged
merged 2 commits into from
Mar 2, 2024
Merged

⭐ add typemaps for simple types #3463

merged 2 commits into from
Mar 2, 2024

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Mar 2, 2024

Basically:

> int(1.23)
1

> bool(1)
true

> float(12)
12

> string(1.89)
"1.89"

> regex("w.r.d") == "world 🌎"
/w.r.d/

chris-rock
chris-rock approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Thank you @arlimus

@arlimus
⭐ add typemaps for simple types
c86f42c 
Basically:

```coffee
> int(1.23)
1

> bool(1)
true

> float(12)
12

> string(1.89)
"1.89"

> regex("w.r.d") == "world 🌎"
/w.r.d/
```

Signed-off-by: Dominik Richter <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024 •
edited
Loading

Test Results

2 829 tests  ±0   2 828 ✅ ±0   1m 27s ⏱️ +12s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 4514f5b. ± Comparison against base commit 7dc1124.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. 
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752#01

go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-02_10:04:34.423581908_+0000_UTC_m=+0.021587731
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-02_10:04:34.423581908_+0000_UTC_m=+0.021587731
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-02_10:04:34.423581908_+0000_UTC_m=+0.021587731#01

♻️ This comment has been updated with latest results.

@arlimus
🟢 separate typemaps from resource calls
4514f5b 
Regex is the biggest offender right now and we need a long-term solution for this

Signed-off-by: Dominik Richter <[email protected]>
@arlimus arlimus merged commit 49857bb into main Mar 2, 2024
14 checks passed
@arlimus arlimus deleted the dom/typemaps branch March 2, 2024 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arlimus @chris-rock