Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Added Trust relationship policy to the role (aws) #3445

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

HRouhani
Copy link
Contributor

Screenshot from 2024-02-28 16-54-23

Screenshot from 2024-02-28 16-54-44

Copy link
Contributor

Test Results

2 829 tests  ±0   2 828 ✅ ±0   1m 15s ⏱️ -4s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit cd56acc. ± Comparison against base commit 01818c3.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-27_14:38:03.910795437_+0100_CET_m=+0.008773223
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_14:38:03.910795437_+0100_CET_m=+0.008773223
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_14:38:03.910795437_+0100_CET_m=+0.008773223#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-27_13:04:58.872036045_+0000_UTC_m=+0.010565752#01

@@ -852,6 +852,8 @@ private aws.iam.role @defaults("arn name") {
tags map[string]string
// Time when the role was created
createDate time
// The policy document that grants an entity permission to assume the role
assumeRolePolicyDocument dict
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we shouldn't make this a real resource object? is there a specific test you're targeting with this resource? what would the query look like with this as a dict vs a defined resource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback. So far I wrote like following:

Screenshot from 2024-02-29 18-39-45

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that makes sense. prob better to just leave as a dict

@tas50 tas50 merged commit e13f4f2 into main Mar 5, 2024
14 checks passed
@tas50 tas50 deleted the hossein/aws-role-attachedpolicy-2 branch March 5, 2024 03:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants