-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ Added Trust relationship policy to the role (aws) #3445
Conversation
HRouhani
commented
Feb 28, 2024
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Test Results2 829 tests ±0 2 828 ✅ ±0 1m 15s ⏱️ -4s Results for commit cd56acc. ± Comparison against base commit 01818c3. This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
|
@@ -852,6 +852,8 @@ private aws.iam.role @defaults("arn name") { | |||
tags map[string]string | |||
// Time when the role was created | |||
createDate time | |||
// The policy document that grants an entity permission to assume the role | |||
assumeRolePolicyDocument dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we shouldn't make this a real resource object? is there a specific test you're targeting with this resource? what would the query look like with this as a dict vs a defined resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that makes sense. prob better to just leave as a dict