Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix shell command panic #3410

Merged
merged 1 commit into from
Feb 22, 2024
Merged

🐛 fix shell command panic #3410

merged 1 commit into from
Feb 22, 2024

Conversation

imilchev
Copy link
Member

the shell command panics when multiple assets are discovered and you do ctrl + C without selecting an asset. This fixes the issue.

Signed-off-by: Ivan Milchev <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imilchev

Copy link
Contributor

Test Results

2 804 tests  ±0   2 803 ✅ ±0   51s ⏱️ +3s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit b809aef. ± Comparison against base commit 123b57d.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-21_16:42:38.466092737_+0100_CET_m=+0.007909480
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_16:42:38.466092737_+0100_CET_m=+0.007909480
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_16:42:38.466092737_+0100_CET_m=+0.007909480#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-21_12:27:35.040447084_+0000_UTC_m=+0.007676064#01

@imilchev imilchev merged commit aaa3a6c into main Feb 22, 2024
14 checks passed
@imilchev imilchev deleted the ivan/fix-shell-panic branch February 22, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants