Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix mock provider panic #3368

Merged
merged 1 commit into from
Feb 20, 2024
Merged

🐛 fix mock provider panic #3368

merged 1 commit into from
Feb 20, 2024

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Feb 20, 2024

The schema is loaded by the coordinator. The mock provider doesn't need to do anything for that

fixes #3364

Signed-off-by: Ivan Milchev <[email protected]>
Copy link
Contributor

Test Results

2 804 tests  ±0   2 803 ✅ ±0   53s ⏱️ +6s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 4d5db9a. ± Comparison against base commit 4e41f00.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-19_16:12:00.231507074_+0100_CET_m=+0.009013176
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_16:12:00.231507074_+0100_CET_m=+0.009013176
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_16:12:00.231507074_+0100_CET_m=+0.009013176#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635#01

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:

cnquery run mock --use-recording /tmp/ubuntu_18.04.json -c "asset.platform" 
→ loaded configuration from /etc/opt/mondoo/mondoo.yml using source default
asset.platform: "ubuntu"

Thanks @imilchev

@imilchev imilchev merged commit f7659f9 into main Feb 20, 2024
14 checks passed
@imilchev imilchev deleted the ivan/mock-provider-panic branch February 20, 2024 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cnquery mock panics
2 participants