Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 make sure core schema cannot be overridden #3362

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Feb 19, 2024

makes sure resources from the core provider cannot be overridden. Also fixes issues with prioritization of resource fields. Added tests!

Signed-off-by: Ivan Milchev <[email protected]>
@imilchev imilchev marked this pull request as draft February 19, 2024 15:43
Signed-off-by: Ivan Milchev <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Test Results

2 804 tests  +8   2 803 ✅ +8   51s ⏱️ -1s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit d001852. ± Comparison against base commit 46e5509.

This pull request removes 3 and adds 11 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_10:55:50.218571799_+0000_UTC_m=+0.009470635#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-19_16:27:55.145333793_+0000_UTC_m=+0.008763551
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_16:27:55.145333793_+0000_UTC_m=+0.008763551
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-19_16:27:55.145333793_+0000_UTC_m=+0.008763551#01
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupFieldProvider
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupFieldProvider_CoreOverridesAll
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupFieldProvider_CoreOverridesAll_ResourceInfo
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupFieldProvider_ProviderOverridesOthers
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupFieldProvider_ProviderOverridesOthers_ResourceInfo
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupResource
go.mondoo.com/cnquery/v10/providers ‑ TestRuntime_LookupResource_CoreOverridesAll
…

♻️ This comment has been updated with latest results.

@imilchev imilchev marked this pull request as ready for review February 19, 2024 16:59
@imilchev imilchev changed the title 🐛 load core schema last 🐛 make sure core schema cannot be overridden Feb 19, 2024
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀

@chris-rock chris-rock merged commit 15a67e9 into main Feb 19, 2024
14 checks passed
@chris-rock chris-rock deleted the ivan/load-core-schema-last branch February 19, 2024 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants