Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cpes resource definition in vSphere #3327

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Feb 15, 2024

Without the import, the resources.json file was created with core.cpe as the resource for cpes. This failed on lookup when compiling a query.

Adding the import creates the resources.json file cpe as the resource for cpes. Then the lookup works again.

Without the import, the resources.json file was created with  as the resource for .
This failed on lookup when compiling a query.

Adding the import creates the resources.json file  as the resource for .
Then the lookup works again.

Signed-off-by: Christian Zunker <[email protected]>
@czunker
Copy link
Contributor Author

czunker commented Feb 15, 2024

Screenshot from 2024-02-15 14-17-06

This shows the difference in the json file between the os provider, where we had the import and the sphere provider were the import was missing.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czunker

Copy link
Contributor

Test Results

2 745 tests  ±0   2 744 ✅ ±0   57s ⏱️ +12s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 6f94b36. ± Comparison against base commit 8b8b029.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-14_13:33:50.18661564_+0100_CET_m=+0.010995316
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_13:33:50.18661564_+0100_CET_m=+0.010995316
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_13:33:50.18661564_+0100_CET_m=+0.010995316#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-14_11:56:07.030723245_+0000_UTC_m=+0.011946430
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_11:56:07.030723245_+0000_UTC_m=+0.011946430
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_11:56:07.030723245_+0000_UTC_m=+0.011946430#01

@chris-rock chris-rock merged commit 61a603a into main Feb 15, 2024
14 checks passed
@chris-rock chris-rock deleted the christian/fix_vsphere_cpes branch February 15, 2024 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants