⭐️ allow to write sbom reports to a file #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 780 tests ±0 2 779 ✅ ±0 53s ⏱️ +5s Results for commit c2bf362. ± Comparison against base commit 305f2aa. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
chris-rock
force-pushed
the
chris-rock/sbom-reports
branch
2 times, most recently
from
0f7fdc7 to
532e56d
Compare
| if outputTarget != "" { | ||
| filename := outputTarget | ||
| if len(boms) > 1 { | ||
| filename = fmt.Sprintf("%s-%d.%s", path.Base(outputTarget), i, path.Ext(outputTarget)) |
There was a problem hiding this comment.
nit/question: this might be a problem in CI/CD setups, a user wouldn't expect that we change the filename. can we not write all boms to one file?
There was a problem hiding this comment.
Mmh, the current format only has one report included, so we would need one file for a sbom.
preslavgerchev
approved these changes
Feb 15, 2024
chris-rock
force-pushed
the
chris-rock/sbom-reports
branch
from
532e56d to
c2bf362
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to write sboms directly to a file: