Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix cloudwatch metrics alarms when sns topic does not exist #3205

Closed
wants to merge 1 commit into from

Conversation

vjeffrey
Copy link
Contributor

@vjeffrey vjeffrey commented Feb 5, 2024

aws.cloudtrail.trails.where: [
  0: {
    logGroup.metricsFilters.where: [
      0: {
        metrics: [
          0: {
            alarms: [
              0: {
                actions: [
                  0: {
                    region: "us-east-1"
                    tags: {}
                    attributes: null
                    subscriptions: null
                    arn: "arn:aws:sns:us-east-1:------------:CISAlarm"
                  }
                ]
              }
            ]
          }
        ]
      }
    ]
  }
]
cnquery> exit

fixes #3204

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test Results

746 tests  ±0   746 ✅ ±0   13s ⏱️ -1s
 84 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 36575a3. ± Comparison against base commit cf84191.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-05_09:01:51.855628223_+0000_UTC_m=+0.008518559
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-05_09:01:51.855628223_+0000_UTC_m=+0.008518559
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-05_09:01:51.855628223_+0000_UTC_m=+0.008518559#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-05_09:49:09.08807371_+0000_UTC_m=+0.007830090
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-05_09:49:09.08807371_+0000_UTC_m=+0.007830090
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-05_09:49:09.08807371_+0000_UTC_m=+0.007830090#01

@preslavgerchev
Copy link
Contributor

Do we still need this? The linked issue is closed

@vjeffrey
Copy link
Contributor Author

Do we still need this? The linked issue is closed

hmm. i guess not, manuel said it's working 🤷

@vjeffrey vjeffrey closed this Feb 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants