Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 ensure example query packs pass our own lint requirements #3081

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Jan 21, 2024

Use our lint requirements to validate our examples. To make this work, we temporarily install the required providers and remove them afterwards. This ensures that other tests like cli tests are not affected by the providers we need here.

@chris-rock chris-rock force-pushed the chris-rock/ensure-examples-pass-lint branch 2 times, most recently from aa1a8f3 to 34ad071 Compare January 21, 2024 11:48
@chris-rock chris-rock force-pushed the chris-rock/ensure-examples-pass-lint branch from 34ad071 to 5769a88 Compare January 21, 2024 12:22
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So true!

@arlimus arlimus merged commit 1da52db into main Jan 22, 2024
10 checks passed
@arlimus arlimus deleted the chris-rock/ensure-examples-pass-lint branch January 22, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants