Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 remove versioned providers for crossProviderList #3025

Closed
wants to merge 1 commit into from
Closed

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Jan 14, 2024

info.Provider is only ever non-versioned and we have updated recordings, so this is no longer necessary

info.Provider is only ever non-versioned and we have updated recordings, so this is no longer necessary

Signed-off-by: Dominik Richter <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arlimus

@arlimus
Copy link
Member Author

arlimus commented Jan 16, 2024

I'm closing this for now in favor of #3037 , I think @chris-rock 's intuition/direction on this is much better than what I was trying to do. Removing it here is too early, considering we have versioned providers out there. The referenced PR also adds deprecation notices.

@arlimus arlimus closed this Jan 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
@arlimus arlimus deleted the dom/v9dep branch January 16, 2024 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants