Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 v10 🎉 #2966

Merged
merged 11 commits into from
Jan 14, 2024
Merged

🎉 v10 🎉 #2966

merged 11 commits into from
Jan 14, 2024

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Jan 7, 2024

@chris-rock chris-rock marked this pull request as draft January 7, 2024 15:43
@arlimus arlimus force-pushed the v10 branch 2 times, most recently from 911fbfb to d7ed6a1 Compare January 12, 2024 17:33
@arlimus arlimus changed the title DRAFT: 🎉 v10 🎉 🎉 v10 🎉 Jan 12, 2024
@arlimus arlimus force-pushed the v10 branch 2 times, most recently from c676dde to 5d96a15 Compare January 12, 2024 18:07
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arlimus

arlimus and others added 6 commits January 14, 2024 17:35
We don't want it in the ID, since they have a separate version info.
Having the ID in the name makes it much trickier to update a provider
(technically).
Signed-off-by: Dominik Richter <[email protected]>
Signed-off-by: Dominik Richter <[email protected]>
Signed-off-by: Dominik Richter <[email protected]>
@chris-rock chris-rock marked this pull request as ready for review January 14, 2024 17:28
@arlimus arlimus merged commit 3e502d0 into main Jan 14, 2024
5 checks passed
@arlimus arlimus deleted the v10 branch January 14, 2024 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants