Skip to content

Commit

Permalink
Fix a gcp resource field typo
Browse files Browse the repository at this point in the history
It's correct in the .lr file, but wrong where it's set.

Also fix a few other misc things and update the spellcheck matchers

Signed-off-by: Tim Smith <[email protected]>
  • Loading branch information
tas50 committed Feb 18, 2024
1 parent c039ed9 commit add3d7e
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 4 deletions.
24 changes: 23 additions & 1 deletion .github/actions/spelling/line_forbidden.patterns
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,31 @@
# s.b. System76
\bSystem 76\b

#
# HashiCorp Products
#

# s.b. HashiCorp
\bHashicorp\b

# s.b. Terraform
\bTerraForm\b

#
# Microsoft Products
#

# s.b. Microsoft
\bMicroSoft\b

# s.b. PowerPoint
\bPower Point\b
\bPowerpoint\b

# s.b. OneNote
\bOne Note\b
\bOnenote\b

# s.b. Windows Server
\bWindows server\b

Expand All @@ -206,12 +224,16 @@

# s.b. BitLocker
\bBitlocker\b

\bbitLocker\b

# s.b. VS Code
\bVSCode\b
\bVScode\b

# s.b. LinkedIn
\bLinked In\b
\bLinkedin\b

#
# VMware Products
#
Expand Down
2 changes: 1 addition & 1 deletion explorer/scan/discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func DiscoverAssets(ctx context.Context, inv *inventory.Inventory, upstream *ups
func createRuntimeForAsset(asset *inventory.Asset, upstream *upstream.UpstreamConfig, recording llx.Recording) (*AssetWithRuntime, error) {
var runtime *providers.Runtime
var err error
// Close the runtime if an error occured
// Close the runtime if an error occurred
defer func() {
if err != nil && runtime != nil {
runtime.Close()
Expand Down
2 changes: 1 addition & 1 deletion llx/code.go
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ func (l *CodeV2) entrypoint2assessment(bundle *CodeBundle, ref uint64, lookup fu
listRef := chunk.Function.Binding
// Find the datapoint linked to this listRef
// For .all(...) queries and alike, all is bound to a list.
// This list only has the resource ids as datpoints.
// This list only has the resource ids as datapoints.
// But earlier on, we also bound a datapoint for the default fields to the list.
// We need to find this datapoint and use it as the listRef.
OUTER:
Expand Down
2 changes: 1 addition & 1 deletion providers/gcp/resources/pubsub.go
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ func (g *mqlGcpProjectPubsubService) snapshots() ([]interface{}, error) {
"projectId": llx.StringData(projectId),
"name": llx.StringData(s.ID()),
"topic": llx.ResourceData(topic, "gcp.project.pubsubService.topic"),
"expirtaion": llx.TimeData(s.Expiration),
"expiration": llx.TimeData(s.Expiration),
})
if err != nil {
return nil, err
Expand Down

0 comments on commit add3d7e

Please sign in to comment.