🐛 fix shell command (#3342)

apps/cnquery/cmd/shell.go

@@ -108,32 +108,32 @@ func StartShell(runtime *providers.Runtime, conf *ShellConfig) error {
 
 	connectAsset := filteredAssets[0]
 	if len(filteredAssets) > 1 {
+		invAssets := make([]*inventory.Asset, 0, len(filteredAssets))
+		for _, a := range filteredAssets {
+			invAssets = append(invAssets, a.Asset)
+		}
+
 		isTTY := isatty.IsTerminal(os.Stdout.Fd())
 		if isTTY {
-			connectAsset = components.AssetSelect(filteredAssets)
+			selectedAsset := components.AssetSelect(invAssets)
+			connectAsset = filteredAssets[selectedAsset]
 		} else {
-			fmt.Println(components.AssetList(theme.OperatingSystemTheme, filteredAssets))
+			fmt.Println(components.AssetList(theme.OperatingSystemTheme, invAssets))
 			log.Fatal().Msg("cannot connect to more than one asset, use --platform-id to select a specific asset")
 		}
 	}
 
 	if connectAsset == nil {
-		log.Fatal().Msg("no asset selected")
+		log.Error().Msg("no asset selected")
+		os.Exit(1)
 	}
 
-	err = runtime.Connect(&plugin.ConnectReq{
-		Features: conf.Features,
-		Asset:    connectAsset,
-		Upstream: conf.UpstreamConfig,
-	})
-	if err != nil {
-		log.Fatal().Err(err).Msg("failed to connect to asset")
-	}
-	log.Info().Msgf("connected to %s", runtime.Provider.Connection.Asset.Platform.Title)
+	log.Info().Msgf("connected to %s", connectAsset.Runtime.Provider.Connection.Asset.Platform.Title)
 
 	// when we close the shell, we need to close the backend and store the recording
 	onCloseHandler := func() {
 		runtime.Close()
+		connectAsset.Runtime.Close()
 		providers.Coordinator.Shutdown()
 	}
 
@@ -142,7 +142,7 @@ func StartShell(runtime *providers.Runtime, conf *ShellConfig) error {
 	shellOptions = append(shellOptions, shell.WithFeatures(conf.Features))
 	shellOptions = append(shellOptions, shell.WithUpstreamConfig(conf.UpstreamConfig))
 
-	sh, err := shell.New(runtime, shellOptions...)
+	sh, err := shell.New(connectAsset.Runtime, shellOptions...)
 	if err != nil {
 		log.Error().Err(err).Msg("failed to initialize interactive shell")
 	}

cli/components/assetselect.go

@@ -12,7 +12,7 @@ import (
 	"go.mondoo.com/cnquery/v10/providers-sdk/v1/inventory"
 )
 
-func AssetSelect(assetList []*inventory.Asset) *inventory.Asset {
+func AssetSelect(assetList []*inventory.Asset) int {
 	list := make([]string, len(assetList))
 
 	// map asset name to list
@@ -36,9 +36,9 @@ func AssetSelect(assetList []*inventory.Asset) *inventory.Asset {
 	}
 
 	if selection == -1 {
-		return nil
+		return -1
 	}
 	selected := assetList[selection]
 	log.Info().Int("selection", selection).Str("asset", selected.Name).Msg("selected asset")
-	return selected
+	return selection
 }

explorer/scan/discovery.go

@@ -57,12 +57,12 @@ func (d *DiscoveredAssets) AddError(asset *inventory.Asset, err error) {
 	d.Errors = append(d.Errors, &AssetWithError{Asset: asset, Err: err})
 }
 
-func (d *DiscoveredAssets) GetAssetsByPlatformID(platformID string) []*inventory.Asset {
-	var assets []*inventory.Asset
+func (d *DiscoveredAssets) GetAssetsByPlatformID(platformID string) []*AssetWithRuntime {
+	var assets []*AssetWithRuntime
 	for _, a := range d.Assets {
 		for _, p := range a.Asset.PlatformIds {
 			if platformID == "" || p == platformID {
-				assets = append(assets, a.Asset)
+				assets = append(assets, a)
 				break
 			}
 		}

explorer/scan/discovery_test.go

@@ -82,7 +82,7 @@ func TestDiscoveredAssets_GetAssetsByPlatformID(t *testing.T) {
 	// Make sure adding duplicates is not possible
 	assets := d.GetAssetsByPlatformID(allPlatformIds[0])
 	assert.Len(t, assets, 1)
-	assert.Equal(t, allPlatformIds[0], assets[0].PlatformIds[0])
+	assert.Equal(t, allPlatformIds[0], assets[0].Asset.PlatformIds[0])
 }
 
 func TestDiscoveredAssets_GetAssetsByPlatformID_Empty(t *testing.T) {
@@ -110,7 +110,7 @@ func TestDiscoveredAssets_GetAssetsByPlatformID_Empty(t *testing.T) {
 	assert.Len(t, assets, 10)
 	platformIds := []string{}
 	for _, a := range assets {
-		platformIds = append(platformIds, a.PlatformIds[0])
+		platformIds = append(platformIds, a.Asset.PlatformIds[0])
 	}
 	assert.ElementsMatch(t, allPlatformIds, platformIds)
 }

providers/aws/resources/discovery.go

@@ -186,11 +186,6 @@ func Discover(runtime *plugin.Runtime, filters connection.DiscoveryFilters) (*in
 		Assets: []*inventory.Asset{},
 	}}
 
-	if (conn.Conf == nil || len(conn.Conf.Discover.Targets) == 0) && conn.Asset() != nil {
-		in.Spec.Assets = append(in.Spec.Assets, conn.Asset())
-		return in, nil
-	}
-
 	res, err := NewResource(runtime, "aws.account", map[string]*llx.RawData{"id": llx.StringData("aws.account/" + conn.AccountId())})
 	if err != nil {
 		return nil, err

providers/aws/resources/discovery_conversion.go

@@ -204,7 +204,7 @@ func accountAsset(conn *connection.AwsConnection, awsAccount *mqlAwsAccount) *in
 		PlatformIds: []string{id},
 		Name:        name,
 		Platform:    connection.GetPlatformForObject(""),
-		Connections: []*inventory.Config{conn.Conf},
+		Connections: []*inventory.Config{conn.Conf.Clone(inventory.WithoutDiscovery(), inventory.WithParentConnectionId(conn.Conf.Id))},
 		Options:     conn.ConnectionOptions(),
 	}
 }