🐛 properly parse flags for commands containing -- (#4730)

Signed-off-by: Ivan Milchev <[email protected]>

.github/workflows/main-benchmark.yml

@@ -46,7 +46,7 @@ jobs:
           path: ./cache
           key: ${{ runner.os }}-benchmark-${{ github.run_id }}
           restore-keys: |
-            ${{ runner.os }}-benchmark
+            ${{ runner.os }}-benchmark-
       # Run `github-action-benchmark` action
       - name: Store benchmark result
         uses: benchmark-action/github-action-benchmark@v1

.github/workflows/pr-test-lint.yml

@@ -155,7 +155,7 @@ jobs:
           path: ./cache
           key: ${{ runner.os }}-benchmark-${{ github.run_id }}
           restore-keys: |
-            ${{ runner.os }}-benchmark
+            ${{ runner.os }}-benchmark-
       # Run `github-action-benchmark` action
       - name: Store benchmark result
         uses: benchmark-action/github-action-benchmark@v1

providers/os/resources/processes/flag.go

@@ -38,6 +38,9 @@ func (f *FlagSet) ParseCommand(cmd string) error {
 	n := len(args)
 	for i := 0; i < n; i++ {
 		key := args[i]
+		if key == "--" {
+			break
+		}
 		if strings.HasPrefix(key, "-") {
 			if i+1 < n && !strings.HasPrefix(args[i+1], "-") {
 				preparedArgs = append(preparedArgs, key+"="+args[i+1])

providers/os/resources/processes/flag_test.go

@@ -120,6 +120,17 @@ func TestFlagParser(t *testing.T) {
 				"node-labels":               "eks.amazonaws.com/sourceLaunchTemplateVersion=1,alpha.eksctl.io/nodegroup-name=ng-1c08897f,alpha.eksctl.io/cluster-name=cluster1,eks.amazonaws.com/nodegroup-image=ami-0656dd273bd6e9a2f,eks.amazonaws.com/capacityType=ON_DEMAND,eks.amazonaws.com/nodegroup=ng-1c08897f,eks.amazonaws.com/sourceLaunchTemplateId=lt-079b3a8f38d6aa1a9",
 			},
 		},
+		{
+			cmd:   "tini -- fleetcontroller gitjob --gitjob-image rancher/fleet:v0.10.2",
+			flags: map[string]string{},
+		},
+		{
+			cmd: "/sbin/agetty -o -p -- \\u --noclear - linux",
+			flags: map[string]string{
+				"o": "",
+				"p": "",
+			},
+		},
 	}
 
 	for i := range tests {