🐛 Handle ssh connection errors (#1844)

Fixes #1812 Fixes #1814 Signed-off-by: Christian Zunker <[email protected]>
mondoohq · Sep 22, 2023 · 66756d7 · 66756d7
1 parent 928afdc
commit 66756d7
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/providers/os/provider/provider.go b/providers/os/provider/provider.go
@@ -300,6 +300,9 @@ func (s *Service) connect(req *plugin.ConnectReq, callback plugin.ProviderCallba
 	case SshConnectionType:
 		s.lastConnectionID++
 		conn, err = connection.NewSshConnection(s.lastConnectionID, conf, asset)
+		if err != nil {
+			return nil, err
+		}
 		fingerprint, err := IdentifyPlatform(conn, asset.Platform, []string{ids.IdDetector_Hostname, ids.IdDetector_CloudDetect, ids.IdDetector_SshHostkey})
 		if err == nil {
 			if conn.Asset().Connections[0].Runtime != "vagrant" {
@@ -311,6 +314,9 @@ func (s *Service) connect(req *plugin.ConnectReq, callback plugin.ProviderCallba
 	case TarConnectionType:
 		s.lastConnectionID++
 		conn, err = connection.NewTarConnection(s.lastConnectionID, conf, asset)
+		if err != nil {
+			return nil, err
+		}
 		fingerprint, err := IdentifyPlatform(conn, asset.Platform, []string{ids.IdDetector_Hostname})
 		if err == nil {
 			asset.Name = fingerprint.Name
@@ -320,6 +326,9 @@ func (s *Service) connect(req *plugin.ConnectReq, callback plugin.ProviderCallba
 	case DockerSnapshotConnectionType:
 		s.lastConnectionID++
 		conn, err = connection.NewDockerSnapshotConnection(s.lastConnectionID, conf, asset)
+		if err != nil {
+			return nil, err
+		}
 		fingerprint, err := IdentifyPlatform(conn, asset.Platform, []string{ids.IdDetector_Hostname})
 		if err == nil {
 			asset.Name = fingerprint.Name
@@ -358,6 +367,9 @@ func (s *Service) connect(req *plugin.ConnectReq, callback plugin.ProviderCallba
 	case FilesystemConnectionType:
 		s.lastConnectionID++
 		conn, err = connection.NewFileSystemConnection(s.lastConnectionID, conf, asset)
+		if err != nil {
+			return nil, err
+		}
 		fingerprint, err := IdentifyPlatform(conn, asset.Platform, []string{ids.IdDetector_Hostname})
 		if err == nil {
 			asset.Name = fingerprint.Name