Skip to content

Commit

Permalink
🧹 refactor npm parser
Browse files Browse the repository at this point in the history
  • Loading branch information
chris-rock committed Feb 15, 2024
1 parent 61a603a commit 43c7992
Show file tree
Hide file tree
Showing 38 changed files with 725 additions and 183 deletions.
14 changes: 14 additions & 0 deletions providers/os/resources/npm/npm.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright (c) Mondoo, Inc.
// SPDX-License-Identifier: BUSL-1.1

package npm

import (
"io"

"go.mondoo.com/cnquery/v10/providers-sdk/v1/upstream/mvd"
)

type Parser interface {
Parse(r io.Reader) ([]*mvd.Package, error)
}
172 changes: 172 additions & 0 deletions providers/os/resources/npm/package_json.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
// Copyright (c) Mondoo, Inc.
// SPDX-License-Identifier: BUSL-1.1

package npm

import (
"encoding/json"
"errors"
"fmt"
"io"
"regexp"
"strings"

"go.mondoo.com/cnquery/v10/providers-sdk/v1/upstream/mvd"
)

// packageJson allows parsing the package json file
type packageJson struct {
Name string `json:"name"`
Description string `json:"description"`
Version string `json:"version"`
Private bool `json:"private"`
Homepage string `json:"homepage"`
License string `json:"license"`
Author *packageJsonPeople `json:"author"`
Contributors []packageJsonPeople `json:"contributors"`
Dependencies map[string]string `jsonn:"dependencies"`
DevDependencies map[string]string `jsonn:"devDependencies"`
Repository packageJsonRepository `json:"repository"`
Engines map[string]string `jsonn:"engines"`
CPU []string `json:"cpu"`
OS []string `json:"os"`
}

// packageJsonPeople represents the author of the package
// https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors
type packageJsonPeople struct {
Name string `json:"name"`
Email string `json:"email"`
URL string `json:"url"`
}

// Explanation:
//
// ^: Asserts the start of the string.
// ([^<]+): Captures one or more characters that are not <. This is for the author's name.
// \s+: Matches one or more whitespace characters.
// <([^>]+)>: Captures the email address within angle brackets.
// \s+: Matches one or more whitespace characters again.
// \(([^)]+)\): Captures the URL within parentheses.
// $: Asserts the end of the string.
var authorPatter = regexp.MustCompile(`^([^<]+)\s+<([^>]+)>\s+\(([^)]+)\)$`)

// UnmarshalJSON implements the json.Unmarshaler interface
// package.json author can be a string or a structured object
func (a *packageJsonPeople) UnmarshalJSON(b []byte) error {
var authorStr string
type authorStruct packageJsonPeople
author := authorStruct{}

// try to unmarshal as structured object
err := json.Unmarshal(b, &author)
if err == nil {
a.Name = author.Name
a.Email = author.Email
a.URL = author.URL
return nil
}

// try to unmarshal as string
err = json.Unmarshal(b, &authorStr)
if err == nil {
matches := authorPatter.FindStringSubmatch(authorStr)
if len(matches) == 4 {
a.Name = matches[1]
a.Email = matches[2]
a.URL = matches[3]
return nil
}
}

return errors.New("could not unmarshal author: " + string(b))
}

func (a *packageJsonPeople) String() string {
b := strings.Builder{}
b.WriteString(a.Name)
if a.Email != "" {
b.WriteString(fmt.Sprintf(" <%s>", a.Email))
}
if a.URL != "" {
b.WriteString(fmt.Sprintf(" (%s)", a.URL))
}
return b.String()
}

type packageJsonRepository struct {
Type string `json:"type"`
URL string `json:"url"`
Directory string `json:"directory"`
}

func (r *packageJsonRepository) UnmarshalJSON(b []byte) error {
var repositoryStr string
type repositoryStruct packageJsonRepository
repo := repositoryStruct{}

// try to unmarshal as structured object
err := json.Unmarshal(b, &repo)
if err == nil {
r.Type = repo.Type
r.URL = repo.URL
r.Directory = repo.Directory
return nil
}

// try to unmarshal as string
err = json.Unmarshal(b, &repositoryStr)
if err == nil {
// handle case where the type is provided as prefix like `bitbucket:`
parts := strings.SplitN(repositoryStr, ":", 2)
if len(parts) == 2 {
r.Type = parts[0]
r.URL = parts[1]
return nil
} else {
r.Type = "github"
r.URL = repositoryStr
return nil
}
}

return errors.New("could not unmarshal repository: " + string(b))
}

type PackageJsonParser struct{}

func (p *PackageJsonParser) Parse(r io.Reader) ([]*mvd.Package, error) {
data, err := io.ReadAll(r)
if err != nil {
return nil, err
}

var packageJson packageJson
err = json.Unmarshal(data, &packageJson)
if err != nil {
return nil, err
}

entries := []*mvd.Package{}

// add own package
entries = append(entries, &mvd.Package{
Name: packageJson.Name,
Version: packageJson.Version,
Format: "npm",
Namespace: "nodejs",
})

// add all dependencies

for k, v := range packageJson.Dependencies {
entries = append(entries, &mvd.Package{
Name: k,
Version: v,
Format: "npm",
Namespace: "nodejs",
})
}

return entries, nil
}
Loading

0 comments on commit 43c7992

Please sign in to comment.