🐛 fix computed filters after compile (#1138)

mondoohq · Apr 6, 2023 · 0597f66 · 0597f66
1 parent c613c65
commit 0597f66
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/explorer/bundle.go b/explorer/bundle.go
@@ -251,6 +251,7 @@ func (p *Bundle) Compile(ctx context.Context) (*BundleMap, error) {
 		if err = pack.Filters.Compile(ownerMrn); err != nil {
 			return nil, errors.Wrap(err, "failed to compile querypack filters")
 		}
+		pack.ComputedFilters.AddFilters(pack.Filters)
 
 		if err := cache.compileQueries(pack.Queries, pack); err != nil {
 			return nil, err

diff --git a/explorer/filters_test.go b/explorer/filters_test.go
@@ -1,6 +1,7 @@
 package explorer
 
 import (
+	"context"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -41,3 +42,17 @@ func TestSummarize(t *testing.T) {
 		assert.Equal(t, "asset.name, filter 2", f.Summarize())
 	})
 }
+
+func TestBundleAssetFilter(t *testing.T) {
+	// load the raw bundle
+	bundle, err := BundleFromPaths("../examples/os.mql.yaml")
+	require.NoError(t, err)
+	assert.Equal(t, 1, len(bundle.Packs))
+	assert.Equal(t, "asset.family.contains(\"unix\")", bundle.Packs[0].Filters.Items["0"].Mql)
+	assert.Equal(t, (*Filters)(nil), bundle.Packs[0].ComputedFilters)
+
+	// check that the computed asset filters are set
+	pbm, err := bundle.Compile(context.Background())
+	require.NoError(t, err)
+	assert.Equal(t, "asset.family.contains(\"unix\")", pbm.Packs["//local.cnquery.io/run/local-execution/querypacks/linux-mixed-queries"].ComputedFilters.Summarize())
+}