New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Josephs/wired module big refactor #128

Open

lim-joseph wants to merge 3 commits into josephs/wired-module from josephs/wired-module-big-refactor

Member

lim-joseph commented Dec 8, 2024 •

edited

Loading

Description

new constants header file
ensure attribute/method access specifiers make sense
removed config method and moved to init
modernized code: initialization lists, pragma once
extract all implementation logic out of header files for consistency
moved sensors to separate folder

Steps to Test

run it on the wired module test rig

lim-joseph added 2 commits

December 8, 2024 20:25


          refactor: code quality overhaul

0723d4a


          fix: make i2c portNum public

b5358c2

lim-joseph requested a review from Jooi025

December 8, 2024 09:40

lim-joseph self-assigned this


          refactor: move sensors into folder & organise imports

0050b1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet